Introduce AbstractAsyncSelector - #6097
Merged
Merged
Conversation
Contributor
jrhee17
marked this pull request as ready for review
February 14, 2025 09:05
ikhoon
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
AbstractEndpointSelectoris a useful abstract which allows users to select andEndpointasynchronously only by implementingAbstractEndpointSelector#selectNow. However, the current implementation has limitations in that 1) OnlyEndpointcan be selected 2) It is difficult to customize the timing when the pending futures must be reconsidered for completion.While working on the introduction of an
XdsPreprocessor#6096, I found it is useful to be able to select a value asynchronously in the following locations:When a request is executed, the request must wait until a
ListenerSnapshotis fetchedarmeria/xds/src/main/java/com/linecorp/armeria/xds/client/endpoint/XdsPreprocessor.java
Line 60 in 6bbc2ac
The
XdsLoadBalancerwhich selects an endpoint must be refreshed either when the encompassedEndpointGroupis updated or when the local cluster is updated.armeria/xds/src/main/java/com/linecorp/armeria/xds/client/endpoint/UpdatableLoadBalancer.java
Line 110 in 6bbc2ac
For ease of implementation and maintainability, I propose that
AbstractAsyncSelectoris abstracted out ofAbstractEndpointSelector. Since it is unclear whether this abstraction is useful for other situations, the class is located in theinternalpackage.Modifications:
AbstractEndpointSelectortoAbstractAsyncSelectorAbstractEndpointSelectorcontains an internalAbstractAsyncSelectorimplementationSelectionTimeoutTest#select_unlimitedto the internal package since it relies on visibility ofListenableFuture#timeoutFutureResult: